kasiazjc commented on PR #29673: URL: https://github.com/apache/superset/pull/29673#issuecomment-2257554849
> @kasiazjc curious on your take on clarifying "proper nouns" here. Happy to tackle as part of this PR, but I also think we may not need to figure out every single label as part of this PR I think in general it looks fine - found one button which is still uppercase though. Do you maybe know why? Is it a different component? <img width="934" alt="image" src="https://github.com/user-attachments/assets/69e8af47-b9cf-46c7-a7a0-c688537c99bc";> Also noting for later: - left tab is not centered <img width="343" alt="image" src="https://github.com/user-attachments/assets/b29ba74c-ba97-4100-8ecf-6b4024c10905";> - if you have time @mistercrunch we can open another issue to change font size and weight of buttons, and also color of the primary button (as currently it's a little bit too light) I have to say I love how the fields look with sentence case labels in control panel etc! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
