justinpark commented on code in PR #29163:
URL: https://github.com/apache/superset/pull/29163#discussion_r1673162549
##########
superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx:
##########
@@ -92,7 +96,7 @@ const ShareSqlLabQuery = ({
};
const getCopyUrl = (callback: Function) => {
if (isFeatureEnabled(FeatureFlag.ShareQueriesViaKvStore)) {
- return getCopyUrlForKvStore(callback);
+ return getCopyUrlForPermalink(callback);
Review Comment:
> I feel we could now remove the feature flag, and make this the default
behavior.
@villebro as @michael-s-molina mentioned, we'll remove the feature flag
during the 5.0 proposal work.
> In addition, I think it would be a good idea to create the permalink based
on the same query snippet that gets executed when running the query - Currently
the entire editor gets persisted into the permalink, even if only a specific
portion of the editor is selected.
Clipping only specific executed sections into a permalink might cause
confusion for some users. Instead, I'm thinking about a method where, if an
area is selected, it automatically highlights the selection in the editor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
