c-w commented on PR #29499: URL: https://github.com/apache/superset/pull/29499#issuecomment-2218767299
> Are you secretly trying to use our docker-compose setup in production!? :) Guilty as charged :) I'm not quite at the stage where moving to k8s makes sense but the self-contained nature of container still adds a ton of value so docker-compose has been wonderful. > Why not simply improving the docs as to how to configure Redis in any superset_config file (production or dev), and clarifying how to alter docker-compose using docker/superset_config_docker.py? Seems you could simply move the custom code in this PR to a local superset_config and roll with it. I hear you. The suggestion definitely works in environments where you have access to a filesystem for setting up a volume mount for the custom config (which isn't always the case, e.g. many cloud offerings that will run your docker image for you won't let you easily do volumes) or it forces you to build your own image that bakes in the custom config (which adds a fair bit of friction on top of being able to just deploy the official image with some environment variable changes). With the changes proposed in this PR, however, the official image turns into something that can be easily configured to externalize all of its state which IMO has value and extends the possible use-cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
