john-bodley commented on code in PR #29164:
URL: https://github.com/apache/superset/pull/29164#discussion_r1633923334
##########
pyproject.toml:
##########
@@ -132,6 +132,7 @@ gevent = ["gevent>=23.9.1"]
gsheets = ["shillelagh[gsheetsapi]>=1.2.18, <2"]
hana = ["hdbcli==2.4.162", "sqlalchemy_hana==0.4.0"]
hive = [
+ "boto3",
Review Comment:
This is imported within the `HiveEngineSpec` and thus likely should be
defined as a depedency.
##########
pyproject.toml:
##########
@@ -154,7 +155,7 @@ pinot = ["pinotdb>=0.3.3, <0.4"]
playwright = ["playwright>=1.37.0, <2"]
postgres = ["psycopg2-binary==2.9.6"]
presto = ["pyhive[presto]>=0.6.5"]
-trino = ["trino>=0.328.0"]
+trino = ["boto3", "trino>=0.328.0"]
Review Comment:
See above.
##########
superset/db_engine_specs/hive.py:
##########
@@ -79,6 +79,12 @@ def upload_to_s3(filename: str, upload_prefix: str, table:
Table) -> str:
)
s3 = boto3.client("s3")
+
+ # The location is merely an S3 prefix and thus we first need to ensure
that there is
Review Comment:
I discovered this issue when testing locally, i.e., given that the location
field is a directory as opposed to a file any file within said directory is
slurped into the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
