justinpark opened a new pull request, #28749: URL: https://github.com/apache/superset/pull/28749
### SUMMARY Currently, the order of the db selector dropdown in SQL Lab is always sorted by record ID, regardless of the intended sort order. This issue arises due to two reasons: 1. an incorrect order_column name is being passed 2. AsyncSelect component's [default sortComparator](https://github.com/apache/superset/blob/07b2449bd777cf04a266f1de3d72af6874b9c305/superset-frontend/src/components/Select/AsyncSelect.tsx#L138) is always sorting by ID. This commit fixes these issues, ensuring that the db selector is sorted by name as originally intended. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ||Before|After| |--|--|--| |API||| |Selector||| ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
