Vitor-Avila opened a new pull request, #28745: URL: https://github.com/apache/superset/pull/28745
### SUMMARY In the process of taking screenshots for an alert/report, Selenium/Playwright is configured to wait a certain time (controlled via `superset_config.py`) until all chart elements are drawn. The logic was configured to monitor the `slice_container` class, however with https://github.com/apache/superset/pull/27255 this class is only used once the chart data is retrieved. This PR changes the class to be monitored to the `chart-container` wrapper. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI changes. ### TESTING INSTRUCTIONS 1. Configure `SCREENSHOT_LOCATE_WAIT` to be 30 seconds, and `SCREENSHOT_LOAD_WAIT` to be 200 seconds. 2. Create a chart that takes longer than 30 seconds to load. You can use `pg_sleep()` with Postgres for example. 3. Configure a report with this chart. Before this PR the report would fail, as the chart wouldn't load within 30 seconds. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
