mistercrunch commented on code in PR #28604:
URL: https://github.com/apache/superset/pull/28604#discussion_r1612165859
##########
superset-frontend/src/components/ErrorBoundary/index.tsx:
##########
@@ -56,6 +58,26 @@ export default class ErrorBoundary extends React.Component<
const messageString = `${t('Unexpected error')}${
firstLine ? `: ${firstLine}` : ''
}`;
+ if (/Loading chunk [\d]+ failed/.test(firstLine)) {
Review Comment:
idk (maybe) it seems the key is in the manifest and the manifest version (?)
`superset/static/assets/manifest.json`. Maybe both the frontend/backend need to
be aware of some sort of manifest SHA and have some sort of handshake / check
around that specifically. Not sure how its generally handled. I believe at
Preset we persist previous assets on a CDN for longer, but it may not be the
best approach for everyone.
I believe there's also something somewhere that checks to see whether you're
still logged in, and redirects you to the login screen if you're not. Maybe
this same ping could check for manifest/app version on top of that (?) Seems
like a common thing in the webpack world, might be worth looking for best
practices around this specific family of issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
