lukaszlenart opened a new pull request, #1936: URL: https://github.com/apache/struts/pull/1936
Last piece of [WW-5702](https://issues.apache.org/jira/browse/WW-5702), after #1934 (scope gaps) and #1935 (provider hygiene). Test-only. ## The ticket's remaining test asks > end-to-end template rendering of `pattern`, and of `required` on radio and file; only `minlength` is currently asserted through a template Added to `Html5ConstraintRenderingTest`, with three new fixture fields on `ConstraintAction`: - `pattern` on a text field (`regex` with `trim=false`, `caseSensitive=true`, a `v`-flag-safe regex) - `required` on every radio of a group — `radiomap.ftl` includes `common-attributes.ftl` once per option, and HTML applies `required` to the group - `required` on a file input - a guard that the text half of a combobox keeps its constraints (see below) The helper gained a `renderTag(Supplier<AbstractUITag>)` so the four tag types share the form setup; the existing tests still go through the same `TextFieldTag` path. Each new test was run once with the `common-attributes` include stripped from `text.ftl`/`radiomap.ftl`/`file.ftl` to confirm it fails. ## Item 12 is a false finding — no template change The ticket lists six html5 templates that "can never render constraints". Checked each: - `combobox.ftl` includes `html5/text.ftl`, which includes `common-attributes.ftl` → `constraints.ftl`. `ComboBox extends TextField`, so the text half already renders `minlength="3" data-msg-stringlength="…"` today (probed by rendering; now pinned by the fourth test). - `datetextfield.ftl` is a stub: *"works only with the JavaTemplates Plugin!"* — the FreeMarker html5 theme never renders the tag. - `doubleselect`, `updownselect`, `optiontransferselect`, `inputtransferselect` are stubs rendering *"not supported in this theme!"* in a `<div>` — there is no input for a constraint to land on. `mvn test -DskipAssembly -pl core`: 3362 tests, 0 failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
