lukaszlenart opened a new pull request, #1929: URL: https://github.com/apache/struts/pull/1929
Fixes [WW-5686](https://issues.apache.org/jira/browse/WW-5686) `Date.end` completes a `java.sql.Date` with `LocalTime.now(tz)`, while `testJavaSqlDate` built its expected string from a `java.sql.Date` captured moments earlier. The two disagree whenever the wall clock crosses a second boundary, which is how the test went red on the SonarCloud job of #1859 (an unrelated OGNL change). The test now uses a fixed `java.sql.Date.valueOf("2024-03-15")` and a date-only `yyyy-MM-dd` format, the same approach `testJavaSqlTime` already takes: it asserts the part of the output the value actually determines and no longer depends on the clock. Proven non-vacuous by temporarily adding `plusDays(1)` to the `java.sql.Date` branch — `expected:<2024-03-1[5]> but was:<2024-03-1[6]>`. `Date.java` is unchanged. Completing a `java.sql.Date` at start of day (the pre-6.2.0 behaviour) alters observable output for time-bearing formats, so it is tracked separately as [WW-5738](https://issues.apache.org/jira/browse/WW-5738) at 8.0.0. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
