lukaszlenart opened a new pull request, #1921:
URL: https://github.com/apache/struts/pull/1921

   Fixes [WW-5731](https://issues.apache.org/jira/browse/WW-5731)
   
   `JasperReport7CsvExporterProvider` set the configured delimiter as both the 
field *and* the record delimiter, so every CSV export came out as a single line 
with the rows joined by `,` (or whatever 
`struts.jasperReport7.csv.defaultDelimiter` / 
`JasperReport7Aware.getCsvDelimiter` returned). Only the field delimiter is 
meant to be configurable — as in the 6.x plugin, which sets `FIELD_DELIMITER` 
alone — so the `setRecordDelimiter` call is dropped and JasperReports' default 
newline applies.
   
   Test `testCsvRecordsAreSeparatedByNewlines` uses `;` as the field delimiter 
and two rows; before the fix the export was `Qux Report;Hello Foo Bar!;Hello 
Baz Qux!;`, now it is three lines.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to