lukaszlenart commented on code in PR #1667:
URL: https://github.com/apache/struts/pull/1667#discussion_r3622756924
##########
.github/workflows/maven.yml:
##########
@@ -20,8 +20,11 @@ on:
push:
branches:
- 'main'
+ - 'develop'
- 'release/*'
- 'support/*'
+ workflow_dispatch:
+ workflow_call:
Review Comment:
Do we need both? Do we reuse this workflow?
##########
pom.xml:
##########
@@ -185,6 +188,71 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>dependency-update-only</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.owasp</groupId>
+ <artifactId>dependency-check-maven</artifactId>
+ <version>${dependencycheck.version}</version>
+ <executions>
+ <execution>
+ <goals>
+ <goal>update-only</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <!-- -DNVD_NIST_APIKEY=${yourkey} so that owasp runs via api -->
Review Comment:
ASF uses `NIST_NVD_API_KEY` and it's already configured for this repo
##########
.github/workflows/maven.yml:
##########
@@ -20,8 +20,11 @@ on:
push:
branches:
- 'main'
+ - 'develop'
Review Comment:
We do not use the "develop" branch, but that's fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
