lukaszlenart opened a new pull request, #1798: URL: https://github.com/apache/struts/pull/1798
Aligns FreeMarker's `incompatible_improvements` setting in `FreemarkerManager` with the FreeMarker 2.3.34 dependency already declared in the build (it was still pinned to `VERSION_2_3_33`). ### Risk None at runtime. FreeMarker 2.3.34 declares `Configuration.VERSION_2_3_34` as an incompatible-improvements break-point, but nothing in 2.3.34 gates behaviour on it: - `_VersionInts` defines `V_2_3_33` but no `V_2_3_34` - the only version comparisons (`BeansWrapper`, `ClassIntrospectorBuilder`) cap at 2.3.33 - the `setIncompatibleImprovements` javadoc change list stops at 2.3.33 So this is purely keeping the setting in sync with the dependency. ### Tests `testIncompatibleImprovementsByOverriding` intentionally stays on `VERSION_2_3_33` — it now asserts a value that differs from the default, so it actually exercises the override path (previously it matched the default and passed trivially). All 26 tests in `org.apache.struts2.views.freemarker.**` pass, including the template rendering/auto-escaping test. Fixes [WW-5580](https://issues.apache.org/jira/browse/WW-5580) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
