lukaszlenart commented on code in PR #1796:
URL: https://github.com/apache/struts/pull/1796#discussion_r3616659258


##########
plugins/cdi/pom.xml:
##########
@@ -39,6 +39,13 @@
             <scope>provided</scope>
         </dependency>
 
+        <dependency>
+            <groupId>org.jboss.weld</groupId>
+            <artifactId>weld-api</artifactId>
+            <version>6.0.Final</version>
+            <scope>provided</scope>
+        </dependency>

Review Comment:
   Thanks — this one doesn't apply. `weld-api` has its own version line, 
independent of `weld-core`/`weld-se`: `org.jboss.weld:weld-api:6.0.4.Final` 
does not exist (404 on Maven Central), and `weld-core-impl:6.0.4.Final` itself 
depends on `weld-api:6.0.Final`. So there is no API/impl mismatch here — 
`6.0.Final` *is* the matching API version for Weld 6.0.4.Final, and aligning it 
to `${weld.version}` would pin a nonexistent artifact.
   
   To make that intent explicit, this has since been moved to a documented 
`<weld-api.version>` property noting it is deliberately distinct from 
`${weld.version}`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to