lukaszlenart opened a new pull request, #1794: URL: https://github.com/apache/struts/pull/1794
## Summary Standardizes the remaining legacy logging in the codebase on Log4j2, the project's standard logging layer, and removes the now-dead first-party SLF4J dependency declarations. Pure refactor/cleanup — **no functional or security behavior changes**. Fixes [WW-5620](https://issues.apache.org/jira/browse/WW-5620). ## Changes - **`FinalizableReferenceQueue`** (core): migrated from `java.util.logging` to Log4j2 (`SEVERE` → `error`, message and throwable preserved). - **`AbstractDefaultToStringRenderable`** (tiles plugin): migrated from SLF4J to Log4j2 (call-compatible `log.error(msg, e)` unchanged). - **`ContainerBuilder`** (core): removed the unused injectable `java.util.logging.Logger` DI factory (a legacy Guice feature — nothing in the repo injects it) along with its now-unused `Member`/`Logger` imports and Javadoc bullet. - **poms** (`core`, `parent`, root): removed the dead first-party SLF4J dependency declarations (core's `slf4j-api` was `optional`, so it never propagated transitively). Runtime bridges (`log4j-slf4j-impl`, `log4j-jcl`) are intentionally left in place. All three migrated/edited source files are vendored (Google Guice / Apache Tiles), so there is no upstream-sync concern. ## Testing - `core`: `mvn test -DskipAssembly -pl core` — 2997 tests pass. - `plugins/tiles`: `mvn test -DskipAssembly -pl plugins/tiles` — 545 tests pass. - Verified no first-party source references `org.slf4j` or `java.util.logging` after the change; the only remaining `slf4j` in any pom is the intentional `apps/showcase` `log4j-slf4j-impl` runtime bridge. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
