lukaszlenart commented on PR #1777:
URL: https://github.com/apache/struts/pull/1777#issuecomment-4952032504
Thanks for the quick turnaround — both changes look good:
- **Per-segment matching** (`cd51fc690`): `containsMalformedPathSegment` now
walks segments with `equals("..")`/`equals(".")` instead of `contains("..")`,
so the `foo..bar.js` false positive is gone. 👍
- **WebJar consolidation** (`cace037c8`): dropping the duplicate segment
loop in `split()` and relying on the shared helper keeps the behavior and gives
a single source of truth. Also nice that `Locale` is now imported rather than
inlined.
Two optional nits, non-blocking:
1. `encoding` (`DefaultStaticContentLoader#encoding`) is now dead — it's
still `@Inject`'d but nothing reads it once the `URLDecoder.decode` is gone.
Could be dropped along with `setEncoding`.
2. The `}` closing `validateStaticContentPath` in
`StaticContentLoader.Validator` is indented at 7 spaces instead of 8 — trivial
formatting.
Neither blocks; happy with the direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
