menggy2025swu commented on PR #7709: URL: https://github.com/apache/shenyu/pull/7709#issuecomment-6379523670
> Ping on state: this PR is approved on the code, but `pr_build` fails and it cannot be merged yet. > > Failing tests in `shenyu-admin`: > > ``` > org.apache.shenyu.admin.service.impl.InstanceCheckServiceTest.testHandleBeatInfoKeepsInstanceInfoWhenBeatCarriesBlank > org.apache.shenyu.admin.service.impl.InstanceCheckServiceTest.testHandleBeatInfoRefreshesInstanceInfoOnExistingIdentity > ``` > > This PR does not touch the instance checker, so this is most likely a test-order or timing interaction with the in-flight instance checker work. Please rerun the job first; if it reproduces, let us know and we will bisect which PR introduced the interaction. Thanks for the review and for pointing this out. I investigated the CI failure and confirmed that this PR does not modify `shenyu-admin`, `InstanceCheckService`, or `InstanceCheckServiceTest`. The changes to the root POM trigger the full reactor build, which includes the existing admin tests. I also ran `InstanceCheckServiceTest` locally 21 times, and all runs passed. However, my local environment differs from the CI environment, so this does not rule out a timing-sensitive test failure under CI conditions. The failure appears potentially related to the existing timing-sensitive test, but I have not yet been able to obtain the full CI test failure stack trace to confirm the exact cause. Could you please help rerun the failed `pr_build` job? If it fails again, the detailed Surefire failure log would help identify the exact cause. I have not changed the unrelated admin test or its implementation, and I would prefer to keep this PR focused on the HTTP gateway bootstrap distribution. Thanks for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
