Aias00 commented on PR #7193:
URL: https://github.com/apache/shenyu/pull/7193#issuecomment-6358906636
Ping on state: this PR is approved on the code, but `pr_build` fails and it
cannot be merged yet. This one looks like a real regression, please take a look.
Failing tests in `shenyu-admin`:
org.apache.shenyu.admin.listener.DataChangedEventDispatcherTest.onApplicationEventNotMasterForwardFailedStillUpdatesLocalCachesTest
org.apache.shenyu.admin.listener.DataChangedEventDispatcherTest.onApplicationEventStandaloneNeverForwardsTest
org.apache.shenyu.admin.listener.DataChangedEventDispatcherTest.onApplicationEventNotMasterForwardsEventAndKeepsAbstractListenersTest
These are all about event dispatching and cache updates, which is what the
cached scale policy changes. Please run the class locally and confirm whether
the assertions need updating or whether the behaviour really changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
