Aias00 commented on PR #7990: URL: https://github.com/apache/shenyu/pull/7990#issuecomment-6356502898
Closing in favour of #7984, which is the one we are landing. Thank you for the completeness of this revision — the `matchRestful` branch, the `CUSTOM_FLOW` scope and the rule-cache path were exactly the missing pieces, and the review of this PR is what drove #7984 to cover positive entries as well. Before closing, I have asked the #7984 author to port the two things here that are genuinely better than what #7984 has: - `restfulSelectorCandidateShouldPreventResultCaching` / `restfulRuleCandidateShouldPreventResultCaching` — the only coverage of the `matchRestful` branch. - the `verify(candidate, never()).getConditionList()` assertion, which proves the cache is actually *hit* rather than merely populated. So your test work is not lost. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
