markjoin123 opened a new pull request, #7987:
URL: https://github.com/apache/shenyu/pull/7987

   Fixes #7973
   
   `shortestResponse` now accounts for outstanding requests. Selection 
increments `inflight`, and Divide decrements it exactly once on success, error, 
or cancellation, without going negative. A historically fast upstream no longer 
keeps every request while its queue grows. A half-open probe that skips the 
balancer increments `inflight` as well, so the release stays paired.
   
   Tests:
   - `ShortestResponseLoadBalancerTest`: the issue's repro (fast avg 10 vs slow 
avg 100, no completions between selections) no longer sends all requests to the 
fast upstream; each selection increments `inflight` once.
   - `DividePluginTest`: after success, error and cancel, `inflight` returns to 
its baseline; a zero count stays zero.
   - Checkstyle and Apache RAT pass on the affected modules.
   
   Make sure that:
   
   - [x] You have read the [contribution 
guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [x] You submit test cases (unit or integration tests) that back your 
changes.
   - [ ] Your local test passed `./mvnw clean install 
-Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to