Aias00 commented on PR #7026: URL: https://github.com/apache/shenyu/pull/7026#issuecomment-6333867484
Cross-PR note, since this changes a documented contract: #7947 (`docs: define client boundaries, compatibility and server evolution`) is in review in the same session, and its `docs/registration-protocol-compatibility.md` currently states the opposite of what this PR introduces. The three places that will be wrong once this merges: 1. **The "Required" preamble** says "'Required' below means needed to carry out the operation, not necessarily a Jakarta @NotNull annotation **or immediate HTTP rejection**. Several controllers accept a DTO without `@Valid` and downstream failures can occur after acknowledgement." After this PR all six endpoints reject with 400 before publishing. 2. **The metadata table** marks `host` as "supply a valid host/port for consumers that also register upstreams" and says "a missing context path can fall back to appName" — this PR requires `contextPath`, `host` and `ruleName`. 3. **The URI table** does not mark `appName`/`host` as required, and describes the old "`contextPath` **or** `appName`" rule — this PR requires `appName`, `contextPath`, `rpcType` **and** `host` for both `/register-uri` and `/offline`. I approved #7947 on the basis that it is accurate for the tree today, with the request that these be corrected in the same release as this PR. Flagging it here so the two do not ship in different versions with contradictory guidance — that file exists specifically so independent client implementations can trust it. Separately, still relevant to this PR: the `RELEASE-NOTES.md` entry for the newly-required fields, and rewriting the description so it no longer describes the `@NotBlank`/`@NotNull`-on-DTOs approach that was replaced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
