hanzhe-one commented on PR #7920:
URL: https://github.com/apache/shenyu/pull/7920#issuecomment-6332446295
Rebased onto `master` (`e36b0605`) and force-pushed with
`--force-with-lease`.
Since #7915 was squash-merged as `be34dd1e`, I dropped the carried
`1cbb0bf6` commit and replayed only the fallback commit onto master:
```bash
git rebase --onto origin/master 1cbb0bf6
fix/ai-response-transformer-gzip-fallback
```
No conflicts. The PR diff is now just the two #7908 files:
```
.../response/AiResponseTransformerPlugin.java | 48 +++++---
.../response/AiResponseTransformerPluginTest.java | 129
++++++++++++++++++++-
```
`AiResponseTransformerPluginTest`: 40/40 pass, 0 checkstyle violations.
Also re-checked the non-blocking notes you left; none applied to this PR's
lines, so I left them alone:
- Note 3 (`registerResultBean()` in the two status tests) — that setup lives
in #7915's tests, which are now on master. This PR's new tests already use the
helper.
- Note 4 (redundant gunzip) — kept deliberately: the two gzip fallback tests
cover different triggers (model error vs. unusable generated body), and each
asserts what the client decodes, not just byte identity.
- Note 5 — `super.writeWith` double-write is unreachable here, left as-is
per your suggestion.
Because the rebase rewrote the branch, the earlier approval no longer
applies and the PR is back to `REVIEW_REQUIRED`. Could you take another look
when you have a moment? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
