imDwAaY commented on PR #7966: URL: https://github.com/apache/shenyu/pull/7966#issuecomment-6333070512
Thanks for the review. 1. Added `ScaleObserverContextTest`. It boots an `AnnotationConfigApplicationContext`, scans only `org.apache.shenyu.admin.scale.monitor.observer`, registers `MetricsMonitor`, and asserts that exactly one `Observer` bean — the discovered `ScaleObserver` — receives the metric update and calls `scaleByAction` exactly once. I verified the test fails when `@Component` is removed from `ScaleObserver`, so the production wiring regression is now covered. 2. Agreed on the merge order. #7964 is approved and should merge first; I will rebase this branch onto master immediately afterwards, which brings in the owner guard (`ScaleService.active`) and makes this PR safe on its own. 3. Also added the strict boundary assertions from the non-blocking comment: metrics of exactly 40.0 and 80.0 produce no action. Current state: 30 targeted tests pass, checkstyle reports 0 violations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
