harshkha3417 commented on PR #7749: URL: https://github.com/apache/shenyu/pull/7749#issuecomment-6329996680
Thanks @Aias00 for the review! I have addressed all review comments in this PR (which owns `InstanceCheckService`): 1. **Shutdown Timeout Visibility:** In `InstanceCheckService.close()`, added a `LOG.warn(...)` alert when `syncDB(5, TimeUnit.SECONDS)` returns `false` due to lock acquisition timeout. 2. **Field Coverage in Copy:** Added `copy.setId(vo.getId())` to `copyInstanceInfoVO` to ensure full field fidelity, and added `testCopyInstanceInfoVO()` test coverage. 3. Rebased onto latest `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
