harshkha3417 commented on PR #7800: URL: https://github.com/apache/shenyu/pull/7800#issuecomment-6330175559
Thanks @Aias00 for the detailed re-review and suggestions! I have addressed all the non-blocking items: 1. **Unified Root Ext Helper:** Collapsed root ext handling into a shared `buildRootExt(currentExt)` helper used by both `update()` and `buildExtParamByParentTag()`, ensuring consistent root ext formatting (`parent: null`) across the board. 2. **Descent Null-Safety:** Added null checks for both `tagDO` and `parentTagDO` in `recurseUpdateTag()` so dangling references to deleted tags don't trigger NPE during traversal. 3. **Map Simplification:** Replaced `ConcurrentHashMap` with `HashMap` for method-local `allDataMap` and `relationMap` in `updateSubTags()`. 4. Rebased onto latest `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
