Copilot commented on code in PR #727: URL: https://github.com/apache/shenyu-dashboard/pull/727#discussion_r4336139199
########## src/routes/System/Instance/state.test.js: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import Instance from "./index"; +import enUS from "../../../locales/en-US.json"; +import zhCN from "../../../locales/zh-CN.json"; + +jest.mock("dva", () => ({ connect: () => (component) => component })); +jest.mock("../../../utils/IntlUtils", () => ({ + getCurrentLocale: jest.fn(), + getIntlContent: (key) => key, +})); + +describe("Instance state column", () => { + let renderState; + + beforeEach(() => { + const instance = new Instance({}); + instance.setState = (update) => { + instance.state = { ...instance.state, ...update }; + }; + instance.initInstanceColumns(); + renderState = instance.state.columns.find( + (column) => column.dataIndex === "instanceState", + ).render; Review Comment: This test reaches into component internals (overriding setState, calling initInstanceColumns, and reading instance.state.columns) to obtain the renderer. That makes the test brittle to refactors of column setup/state shape. A more maintainable approach is to extract the instance-state render logic into a small exported helper (or exported column factory) and unit test that directly, while the component consumes the same helper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
