Aias00 commented on PR #7895:
URL: https://github.com/apache/shenyu/pull/7895#issuecomment-6308156575
`pr_build` failed on `42242891`, but the failure is **not caused by this
PR**.
```
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
33.221 s
<<< FAILURE! - in
org.apache.shenyu.admin.discovery.ZookeeperClientDiscoveryIntegrationTest
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as
... expected: <[127.0.0.1:19195]> but was: <[]> within 15 seconds.
at
ZookeeperClientDiscoveryIntegrationTest.assertSyncSnapshot(ZookeeperClientDiscoveryIntegrationTest.java:251)
at
ZookeeperClientDiscoveryIntegrationTest.testClientRegistrationAndInstanceChanges(...:162)
```
That test drives embedded ZooKeeper registration/discovery sync through
`AbstractSpringIntegrationTest`; this PR only touches the Swagger document
import path (`UpstreamInstance`, `SwaggerImportServiceImpl`, `DocManagerImpl`,
`LoadServiceDocEntryImpl`, `PullSwaggerDocServiceImpl`) and never reaches
`DiscoveryDataChangedEventSyncListener` or the ZK repository. The assertion
never observed the first instance at all (`was: <[]>`), and the test burned 27
s of its 33 s before the 15 s Awaitility window expired — this is the known
flakiness of that integration test on a loaded runner, not a regression here.
Could you please push an empty commit (or re-run the failed job once the run
finishes) so `pr_build` gets a clean pass? The code review itself is approved —
nothing to change on the diff. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
