cloudbase-ai opened a new pull request, #7898:
URL: https://github.com/apache/shenyu/pull/7898
Fixes #6032.
`./mvnw clean package -Prelease,docker` currently creates the distribution
archives but never invokes Docker image building: Fabric8's `build` goal
defaults to the `install` phase, and neither distribution module overrides that
phase.
Bind the existing Docker build execution explicitly to `package` in both
Admin and Bootstrap distributions. With `release,docker` enabled, the assembly
execution runs first and produces the archive consumed by each Dockerfile. The
Docker profile remains opt-in.
Validation:
- Before the change, `package -Prelease,docker -Ddocker.skip=true
-Dassembly.skipAssembly=true` succeeds without scheduling either `docker:build`
execution. After the change, both executions are scheduled after their
respective assembly goals.
- The following focused `verify` succeeds, produces both real distribution
archives and SHA-512 checksums, and passes Checkstyle and Apache RAT:
```sh
./mvnw -B -ntp -nsu \
-pl shenyu-dist/shenyu-admin-dist,shenyu-dist/shenyu-bootstrap-dist \
-Prelease,docker verify -Ddocker.skip=true -DskipTests \
-DskipRemoteResources=true -Djacoco.skip=true -Dmaven.javadoc.skip=true
```
This validation uses installed prerequisite artifacts. Actual Docker image
builds and runtime tests were not run; the change only adjusts lifecycle
bindings.
Make sure that:
- [x] You have read the [contribution
guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your
changes. Maven lifecycle and archive validation is described above; no runtime
code changes.
- [ ] Your local test passed `./mvnw clean install
-Dmaven.javadoc.skip=true`. Focused distribution verification is described
above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
