klT45 commented on PR #7874: URL: https://github.com/apache/shenyu/pull/7874#issuecomment-6286260284
Thanks for the follow-up. I have pushed 17e04f932 addressing the code review feedback: - compile the raw regex before the replacement dry-run, with regressions for a trailing backslash at both the common utility and Admin validation boundaries; - rename the helper to `applicabilityProblem`; - remove the ineffective suppression directives and CHECKSTYLE disable block; - assert our own replacement-error prefix rather than `No group 1`. Full local unit tests passed: common 519 (4 skipped), admin 2122 (1 skipped), rewrite 23, all with 0 failures/errors. Checkstyle and RAT also passed. The PR description now reflects these changes and explicitly marks CodeQL as unresolved. I also verified why the suppression attempts failed. The CodeQL maintainers state that inline `lgtm` suppression is not supported by GitHub Code Scanning: https://github.com/github/codeql/issues/9298#issuecomment-1136450318 . The standalone `codeql[...]` version at 5c8503a5d, standalone `lgtm[...]` at 85840d878, and trailing variant at 7cd705274 all produced the hosted alert. I did not run a local CodeQL CLI or observe local suppression success. I understand your latest “this must be handled” comment as keeping this item open, not permission to ignore the check. I have retained full validation rather than hiding taint or weakening the feature. Could you confirm whether you want the exact intentional-regex alert triaged/dismissed through the repository's security workflow, as suggested in your earlier follow-up, or a different security constraint on configurable rewrite regexes? I cannot dismiss repository alerts with this account. No claim is made that matching an empty string bounds arbitrary pattern compilation resources or that dismissal automatically makes the current check green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
