Aias00 commented on PR #7865: URL: https://github.com/apache/shenyu/pull/7865#issuecomment-6281615471
CI is currently **red on `pr_build`** (12 test failures in `WebsocketDataChangedListenerNamespaceTest`): `capture()` still stubs the old `WebsocketCollector.send(String, String, DataEventTypeEnum)`, while `WebsocketDataChangedListener` now calls `sendConfiguration(namespaceId, WebsocketData<?>, type)`. The static mock never fires, `raw` stays empty, and the assertions expecting `2`/`1` messages get `0`. A prior reviewer (@wy471x) already flagged this as the **sole blocking item** in their CHANGES_REQUESTED review: once `WebsocketDataChangedListenerNamespaceTest#capture()` is migrated to stub `sendConfiguration`, serialize the captured `WebsocketData<?>`, and parse that JSON (the existing assertions can stay), this should be good to go. The head commit (`0fdc89b1e5`) was pushed *before* that review and the failure is still present, so please push the namespace-test migration and get `pr_build` green before this can be merged. (Per review policy: CI execution error → asking the contributor to handle.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
