Aias00 commented on PR #7677:
URL: https://github.com/apache/shenyu/pull/7677#issuecomment-6260967363
Status update after the master fix landed: the inherited
`InstanceCheckServiceTest` failures are gone, but the re-run now surfaces a
**compile error that is specific to this PR**, so it needs one more commit
before it can merge.
## The failure
```
[shenyu-plugin-base] [ERROR] .../AbstractShenyuPluginTest.java:[311,22]
cannot find symbol
symbol: method setLoged(boolean)
location: variable ruleData of type org.apache.shenyu.common.dto.RuleData
[shenyu-plugin-base] [ERROR] .../AbstractShenyuPluginTest.java:[331,22]
cannot find symbol
symbol: method setLoged(boolean)
```
## Why
`AbstractShenyuPluginTest` is one of the files this PR renames, but master
gained two new test methods in that same file *after* this branch was cut:
```
a186c1c fix(log): reduce routine matching and configuration-sync log volume
(#7643) (#7663) 2026-10-17 05:47
```
Those two methods
(`defaultStrategyRuleMatchShouldNotLogWhenLoggingDisabled`,
`defaultStrategyRuleMatchShouldLogExactlyOnceWhenLoggingEnabled`) call
`ruleData.setLoged(...)`. Because they occupy regions this PR did not touch,
the merge succeeds without a textual conflict and leaves the renamed setter
next to the old call sites — the classic "merges cleanly, does not compile"
case.
I verified the complete set on the merge ref of this pull request: there are
exactly **two** leftovers and both are in that file.
```
git grep -nE "setLoged|getLoged|isLoged" <merge-ref> -- "*.java"
# AbstractShenyuPluginTest.java:311: this.ruleData.setLoged(false);
# AbstractShenyuPluginTest.java:331: this.ruleData.setLoged(true);
```
## Fix
Rebase onto master and rename those two call sites to `setLogged`:
- `AbstractShenyuPluginTest.java:311` -> `this.ruleData.setLogged(false);`
- `AbstractShenyuPluginTest.java:331` -> `this.ruleData.setLogged(true);`
Nothing else is needed — every other `loged` occurrence on master is already
covered by this PR.
Two non-blocking reminders from my earlier review still stand, and are worth
folding into the same push since you are touching the branch anyway:
1. `ALTER TABLE ... RENAME COLUMN` requires MySQL 8.0+. Either state the
requirement in the script header and release notes, or switch to `CHANGE
COLUMN`, which works on 5.7 as well.
2. `@SerializedName(value = "logged", alternate = "loged")` serialises as
`logged`, so the dashboard in `apache/shenyu-dashboard` needs a matching change
before this ships.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
