hanzhe-one commented on PR #7806: URL: https://github.com/apache/shenyu/pull/7806#issuecomment-6259186850
Both non-blocking observations are now addressed in 111d83e: 1. **Hot path allocation.** The normalized prefix is computed once in the constructor and stored in a `transient` field, so `buildDomain()` is back to a single concatenation and no longer allocates on the request path. The field is `transient` so it stays out of the serialized upstream; there is an assertion for that in the existing serialization test. 2. **Degenerate inputs.** `normalizeProtocol` now falls back to `http://` when the stripped scheme is empty, so `":"` and `"/"` no longer produce `://host:port`. Both cases are covered in `buildDomainShouldNormalizeBareProtocols`, and `":"` also in the overload test. `shenyu-loadbalancer`: 60 tests, 0 failures; `checkstyle:check`: 0 violations. The workflows for this branch are still in `action_required` — could a committer approve the run so `pr_build` and `rat_check` execute? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
