harshkha3417 commented on PR #7835:
URL: https://github.com/apache/shenyu/pull/7835#issuecomment-6258960512
Thanks @Aias00 for the thorough review and catch!
### Updates
1. **Removed local error mapping divergence:** Dropped `executeWithoutRetry`
and `isDefaultTransientError` entirely. When `retryTimes <= 0`, `response`
flows directly into the existing outer `.onErrorMap` chain. Upstream timeouts
consistently produce `504 GATEWAY_TIMEOUT` across all configurations, and the
misleading "retry times exceeded" message is eliminated.
2. **Updated tests:** Adjusted `AbstractHttpClientPluginTest` to assert
uniform `504` status on zero-retry timeouts.
3. **Performance clarification:** On routes with `retryTimes <= 0`, every
request bypasses:
- `RetryStrategy` allocation (`new DefaultRetryStrategy<>(this)`, etc.)
- `RetryBackoffSpec` and `Retry.backoff(...)` builder/instance
instantiation
- Jitter, filter predicate, and exhaustion lambda allocations
- Project Reactor `retryWhen(...)` operator chain assembly
- Redundant `.timeout(totalTimeout)` operator attachment (since
`.timeout(duration)` already bounds the single attempt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
