Aias00 commented on issue #7716:
URL: https://github.com/apache/shenyu/issues/7716#issuecomment-6243663054
> Hi, I'd like to work on this issue.
>
> I reproduced the HTTP double encoding and legacy stored/heartbeat values,
and checked the WebSocket path with executable regressions. The ordinary
WebSocket case already passes because `convertToMap` recursively parses
JSON-looking strings; that recursion instead changes nested string values. The
proposed contract keeps `instanceInfo` as a string containing a JSON object, so
consumers can parse it once without changing nested values.
>
> The local patch removes HTTP re-encoding, extracts WebSocket metadata
without recursive conversion, normalizes optional information at the shared
heartbeat boundary, and normalizes one known legacy string-wrapped object
representation when reading stored records. Missing/invalid optional
information falls back to `{}` without stopping heartbeat processing. The
original regression run reports 5 cases, 4 failures and the ordinary WebSocket
control passing; all 132 targeted cases pass after the patch, including H2
legacy-read coverage. Admin and its 28-project prerequisite reactor also pass
`clean verify` (2,741 reported tests, 2 skipped, no failures/errors), including
Checkstyle and RAT.
>
> Please let me know if this overlaps with existing work or if there are
compatibility requirements I should account for.
comment /assign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]