Aias00 commented on code in PR #7684:
URL: https://github.com/apache/shenyu/pull/7684#discussion_r4300759263
##########
shenyu-plugin/shenyu-plugin-httpclient/src/main/java/org/apache/shenyu/plugin/httpclient/config/HttpClientProperties.java:
##########
@@ -583,6 +590,42 @@ public void setMetrics(final Boolean metrics) {
public Boolean getMetrics() {
return metrics;
}
+
+ /**
+ * Gets max pending acquires.
+ *
+ * @return the max pending acquires
+ */
+ public Integer getMaxPendingAcquires() {
+ return maxPendingAcquires;
+ }
+
+ /**
+ * Sets max pending acquires.
+ *
+ * @param maxPendingAcquires the max pending acquires
+ */
+ public void setMaxPendingAcquires(final Integer maxPendingAcquires) {
+ this.maxPendingAcquires = maxPendingAcquires;
+ }
+
+ /**
+ * Gets pending acquire max count.
+ *
+ * @return the pending acquire max count
+ */
+ public Integer getPendingAcquireMaxCount() {
+ return maxPendingAcquires;
+ }
+
+ /**
+ * Sets pending acquire max count.
+ *
+ * @param pendingAcquireMaxCount the pending acquire max count
+ */
+ public void setPendingAcquireMaxCount(final Integer
pendingAcquireMaxCount) {
Review Comment:
[nit] The alias pair works via relaxed binding, but if both
`maxPendingAcquires` and `pendingAcquireMaxCount` are present in configuration
the last one bound wins, which is order-dependent and not documented. Consider
stating the precedence in the javadoc (e.g. "alias of maxPendingAcquires; when
both are set, the last one bound wins"), or exposing only the getter for the
alias.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
