sunnysabor commented on PR #7397: URL: https://github.com/apache/shenyu/pull/7397#issuecomment-6171201603
Thanks for the follow-up. I checked the updated #7381 and merged #7543 before changing these draft contracts. @hengyuss confirmed that #7543 imported the runnable layered foundation from #7531 and completed #7381. This draft already has three `ShenyuAiApiContractTest` tests for unknown-field serialization, SPI annotations, and SPI implementation loading. They do not validate a real Protocol–Provider–Transport path, so they are not evidence that these experimental contracts match the now-merged transport. In particular, this draft proposes mandatory ShenYu SPI and a ByteBuffer boundary, while the accepted implementation uses its own factories and reactive byte-array responses. I am closing this draft as superseded by #7543 rather than introducing a second contract family. The ownership/compatibility concerns should be evaluated against the accepted implementation if further changes are needed. No claim that this draft is ready or its outstanding checks have passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
