(shenyu) branch master updated: fix(admin): stop MetaDataTransfer.mapToVO dropping the namespace id (#7388)

[liuhongyu]

This is an automated email from the ASF dual-hosted git repository.

Aias00 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shenyu.git


The following commit(s) were added to refs/heads/master by this push:
     new 7a752d5f36 fix(admin): stop MetaDataTransfer.mapToVO dropping the 
namespace id (#7388)
7a752d5f36 is described below

commit 7a752d5f367f8c0a4303a584bb80b5d0cbb747e6
Author: Sean-Walker0 <jast_...@foxmail.com>
AuthorDate: Wed Oct 14 09:34:46 2026 +0800

    fix(admin): stop MetaDataTransfer.mapToVO dropping the namespace id (#7388)
    
    * fix(admin): stop MetaDataTransfer.mapToVO dropping the namespace id
    
    #7324 fixed the write paths (copy() and mapToData) but the read path
    kept dropping the field: mapToVO builds MetaDataVO from MetaDataDO for
    the metadata list/detail APIs without copying namespaceId, so every
    row is reported with a null namespace even though the stored metadata
    is namespaced. Copy it like every other field, completing the fix
    started by #7324.
    
    The new test follows the testCopyKeepsNamespaceId convention from
    #7324 and fails on current master with expected <ns-1> but was
    <null>.
    
    Verified with ./mvnw test -pl shenyu-admin -am and
    ./mvnw checkstyle:check -pl shenyu-admin (module-scoped).
    
    * ci: retrigger checks (e2e family hit the known httpbin/cluster flakes)
    
    ---------
    
    Co-authored-by: Sean-Walker0 
<309789691+sean-walk...@users.noreply.github.com>
---
 .../java/org/apache/shenyu/admin/transfer/MetaDataTransfer.java   | 1 +
 .../org/apache/shenyu/admin/transfer/MetaDataTransferTest.java    | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git 
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/transfer/MetaDataTransfer.java
 
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/transfer/MetaDataTransfer.java
index ce15f038e5..11b194907c 100644
--- 
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/transfer/MetaDataTransfer.java
+++ 
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/transfer/MetaDataTransfer.java
@@ -188,6 +188,7 @@ public enum MetaDataTransfer {
                     metaDataVO.setRpcExt(metaDataDO.getRpcExt());
                     metaDataVO.setId(metaDataDO.getId());
                     metaDataVO.setEnabled(metaDataDO.getEnabled());
+                    metaDataVO.setNamespaceId(metaDataDO.getNamespaceId());
                     
metaDataVO.setDateCreated(Optional.ofNullable(metaDataDO.getDateCreated())
                             .map(u -> 
DateUtils.localDateTimeToString(u.toLocalDateTime())).orElse(null));
                     
metaDataVO.setDateUpdated(Optional.ofNullable(metaDataDO.getDateUpdated())
diff --git 
a/shenyu-admin/src/test/java/org/apache/shenyu/admin/transfer/MetaDataTransferTest.java
 
b/shenyu-admin/src/test/java/org/apache/shenyu/admin/transfer/MetaDataTransferTest.java
index 139b88f23c..9ace42d402 100644
--- 
a/shenyu-admin/src/test/java/org/apache/shenyu/admin/transfer/MetaDataTransferTest.java
+++ 
b/shenyu-admin/src/test/java/org/apache/shenyu/admin/transfer/MetaDataTransferTest.java
@@ -143,6 +143,14 @@ public final class MetaDataTransferTest {
         assertEquals("ns-1", metaData.getNamespaceId());
     }
 
+    @Test
+    public void testMapToVOKeepsNamespaceId() {
+        metaDataDTO.setNamespaceId("ns-1");
+        MetaDataDO metaDataDO = 
MetaDataTransfer.INSTANCE.mapToEntity(metaDataDTO);
+        MetaDataVO metaDataVO = MetaDataTransfer.INSTANCE.mapToVO(metaDataDO);
+        assertEquals("ns-1", metaDataVO.getNamespaceId());
+    }
+
     @Test
     public void testMapToDataAll() {
         MetaDataDO metaDataDO = 
MetaDataTransfer.INSTANCE.mapToEntity(metaDataDTO);