konlue opened a new pull request, #7618:
URL: https://github.com/apache/shenyu/pull/7618
Fixes #7609
#### What is the purpose of the change
Build hygiene cleanup in the root POM, as requested in the issue:
1. Remove the misspelled property `<log4j-1.2-api.vetsion>` — it has no
references anywhere in the repository (neither the misspelled nor the correctly
spelled form), so it is removed rather than renamed.
2. Remove the `log4j:log4j` exclusion under the
`org.apache.zookeeper:zookeeper` entry in `<dependencyManagement>` — obsolete
with zookeeper 3.9.5.
#### Brief changelog
- `pom.xml`: drop one property line and the zookeeper `log4j:log4j`
exclusion block.
#### Verifying this change
- `grep -rn "log4j-1.2-api" --include="*.xml" .` → only the removed
definition line existed; no `${...}` references before or after the change, so
no dangling references.
- zookeeper POM check: `org.apache.zookeeper:zookeeper:3.9.5` declares no
log4j dependency.
- Empirical check: with the exclusion removed, `./mvnw -pl
shenyu-infra/shenyu-infra-zookeeper dependency:tree -Dincludes=log4j:log4j`
returns zero hits while zookeeper 3.9.5 still resolves (transitively via
curator).
- Build green: `./mvnw -B validate -pl
shenyu-common,shenyu-spi,shenyu-registry/shenyu-registry-api,shenyu-infra/shenyu-infra-common
-am` SUCCESS; and `./mvnw -B install -DskipTests -Dmaven.javadoc.skip=true -pl
shenyu-registry/shenyu-registry-api,shenyu-registry/shenyu-registry-zookeeper
-am` — 9/9 modules SUCCESS (BUILD SUCCESS in 21.9s, incl.
`shenyu-infra-zookeeper` which resolves zookeeper 3.9.5 transitively via
curator). Full reactor build runs in CI.
#### Checklist
- [x] I have read the [contributor
guide](https://shenyu.apache.org/community/contributor-guide).
- [x] Unit tests / integration tests added or modified: not applicable —
POM-only cleanup, no production code touched.
- [x] Local build passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
