Aias00 opened a new issue, #7607:
URL: https://github.com/apache/shenyu/issues/7607
## Summary
Two Apache Commons dependencies declared in `shenyu-admin/pom.xml` are
effectively dead and should be removed.
## Evidence
- **`commons-io`** — declared at `shenyu-admin/pom.xml:296-298`
(`<version>${commons-io.version}</version>`).
`git grep org.apache.commons.io` across `shenyu-admin/` (main **and**
test) returns **0 matches** → no source usage.
- **`commons-collections4`** — declared at `shenyu-admin/pom.xml:186-187`.
The only two files importing `org.apache.commons.collections4` are:
-
`shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/ApiDocController.java`
-
`shenyu-admin/src/main/java/org/apache/shenyu/admin/service/manager/impl/DocManagerImpl.java`
Both belong to the apidoc viewer that is being removed by #7592 / #7593.
Once those land, this dependency has no consumer.
## Action
1. `commons-io` can be removed independently now (no source usage) — confirm
with `mvn -pl shenyu-admin dependency:analyze`.
2. `commons-collections4` removal is **gated on #7592/#7593**: after the
apidoc viewer is deleted, re-run `mvn -pl shenyu-admin dependency:analyze` to
confirm it becomes an "Unused declared dependency".
3. Remove the corresponding `<dependency>` blocks from
`shenyu-admin/pom.xml`.
4. Drop the now-orphaned `<commons-io.version>` property if no other module
references it (cross-check `git grep commons-io.version`). Keep
`commons-collections4` in root `<dependencyManagement>` only if used elsewhere;
otherwise drop.
## Acceptance
- `mvn -pl shenyu-admin dependency:analyze` reports neither as unused after
cleanup.
- Build + CI green.
## Related
- #7592, #7593 (apidoc removal, gates `commons-collections4`)
- #7583 (dependency cleanup umbrella)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
