Aias00 opened a new issue, #7583:
URL: https://github.com/apache/shenyu/issues/7583

   ## Context
   
   PR #7508 externalized Consul support to `shenyu-plugin-store` (documented in 
`docs/plugin-store-consul.md`, which the root README links to) and removed the 
Consul registry implementation from this repository.
   
   ## Problem
   
   The module directory `shenyu-registry/shenyu-registry-consul` was left 
behind and is now dead, unbuildable code:
   
   - The directory contains exactly **one** file: 
`src/test/java/org/apache/shenyu/registry/consul/TtlSchedulerTest.java`
   - That test references a `TtlScheduler` class that **no longer exists 
anywhere in the repository** — `git grep "class TtlScheduler" HEAD` matches 
only the test file itself — so it cannot compile.
   - The directory has **no `pom.xml`**.
   - It is **not** listed in `shenyu-registry/pom.xml`'s `<modules>`, which 
declares only `api`, `core`, `zookeeper`, `etcd`, `nacos`, `apollo`, `eureka`, 
`kubernetes`.
   
   Because the module is not part of any Maven reactor, nothing ever compiles 
or runs this file, so the breakage is invisible to CI. It only serves to 
confuse contributors browsing the registry module list, who may conclude that 
Consul is still a supported in-repo provider.
   
   ## Suggested fix
   
   Delete the `shenyu-registry/shenyu-registry-consul` directory (the single 
test file). No other change is required — the root README already documents 
Consul as an external plugin-store extension, and no `pom.xml` references the 
module.
   
   ## Verification
   
   ```
   $ git ls-tree -r HEAD:shenyu-registry/shenyu-registry-consul
   100644 blob 1fec36305d43b6970a20918b9e0b62f2c9bd2413  
src/test/java/org/apache/shenyu/registry/consul/TtlSchedulerTest.java
   
   $ git grep -l "class TtlScheduler" HEAD
   
HEAD:shenyu-registry/shenyu-registry-consul/src/test/java/org/apache/shenyu/registry/consul/TtlSchedulerTest.java
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to