Aias00 commented on PR #7567: URL: https://github.com/apache/shenyu/pull/7567#issuecomment-6126612797
Marking this DRAFT, so I won't approve. The new `shenyu-plugin-wasm-base/README.md` documents the WASM host ABI (request/config/result bridge and the discovery callback contract) and the test guests (`go-discovery-handler`, `rust-discovery-handler`) are updated, which is good foundational documentation for the WASM plugin series. Before it is ready for merge, please ensure: 1. The README and the actual exported symbols stay in sync as the sibling PRs (#7568, #7569) land — they evolve together, so merge order matters. 2. The referenced `wat2wasm` / `cargo` fixture-regeneration steps are captured in CI so the committed `.wasm` binaries remain reproducible. 3. Any interface methods referenced by the docs (e.g. `DiscoveryUpstreamDataHandler.removeDiscoveryUpstreamData`, the bridge `get_args`/`put_result` contract) are present on the merged base. Ping me when it is marked ready for a full review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
