yangjj-iso opened a new pull request, #7554:
URL: https://github.com/apache/shenyu/pull/7554
Changing only the Apache Dubbo registry group or consumer pool settings
triggers reference invalidation while `ApacheDubboConfigCache` retains the old
effective configuration. Include group in registry change detection and replace
changed consumer settings before references are destroyed.
Build consumer candidates from freshly loaded Dubbo defaults before applying
plugin overrides, so clearing fields restores defaults and unchanged effective
settings reuse the current objects. Preserve the registry group when copying a
registry to add a namespace, so rebuilt namespaced references receive the
updated group.
Fixes #7437.
## Validation
- Added 17 regression scenarios covering group-only updates and clearing
with/without a namespace, each consumer pool field, partial/full removal, an
explicit `dubbo.consumer.threads` default, unchanged-config reuse, and
configuration observed when old references are destroyed.
- Against the original implementation, the initial regression set reports 13
assertion failures and zero errors; the fixed targeted suite passes.
- All tests in the Dubbo common and Apache Dubbo modules pass: 62 tests,
zero failures/errors/skips (10 common, 52 Apache Dubbo).
- Checkstyle reports zero violations. RAT and `git diff --check` pass.
```bash
./mvnw -B -ntp -pl :shenyu-plugin-apache-dubbo -am \
-Dtest=ApacheDubboConfigCacheTest,ApacheDubboPluginDataHandlerTest,ApacheDubboPluginTest,ApacheDubboMetaDataHandlerTest,ApacheDubboProxyServiceTest,ApacheDubboGrayLoadBalanceTest,SharedThreadPoolTest,DubboConfigCacheTest,DubboParamResolveServiceTest,AbstractDubboPluginTest,DubboShenyuContextDecoratorTest,AbstractDubboPluginDataHandlerTest
\
-Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false \
-Djacoco.skip=true -Dmaven.javadoc.skip=true test apache-rat:check
```
No deployed Dubbo registry/provider integration test was run.
Make sure that:
- [x] You have read the [contribution
guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your
changes.
- [ ] Your local test passed `./mvnw clean install
-Dmaven.javadoc.skip=true`. The affected-module validation is recorded above;
the full repository build was not run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
