lymerin commented on PR #7447: URL: https://github.com/apache/shenyu/pull/7447#issuecomment-6091515999
> Reviewed current head `949918002ad1`. > > The recovery path now uses the namespace-qualified key stored in ConfigDataCache.group instead of rebuilding a second prefixed key. The tests cover both same-namespace recovery and the ns1/ns1_ns1 collision shape. > > Validation: exact-head targeted Maven reactor tests passed on Java 17. > > ```shell > ./mvnw -pl shenyu-admin -am test -Dtest=HttpLongPollingDataChangedListenerTest -Dsurefire.failIfNoSpecifiedTests=false -Drat.skip=true -Djacoco.skip=true -DskipRemoteResources=true -Dmaven.javadoc.skip=true > ``` > > GitHub still reports failing checks: [e2e](https://github.com/apache/shenyu/actions/runs/37667735535/job/112974048928), [e2e-storage (shenyu-e2e-case-storage, e2e-mysql-compose)](https://github.com/apache/shenyu/actions/runs/37667735535/job/112960839547). This review does not claim those checks have passed. Update: CI is now passing on `3cb85db89`, including the RocketMQ logging and MySQL storage E2E checks. The earlier failures appear to have been intermittent: the checks passed after retries, with no code or test changes between the last failed run and this successful run. [[Successful E2E run](https://github.com/apache/shenyu/actions/runs/37968877578)](https://github.com/apache/shenyu/actions/runs/37968877578) ยท [[Successful CI run](https://github.com/apache/shenyu/actions/runs/37968877956)](https://github.com/apache/shenyu/actions/runs/37968877956) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
