Sean-Walker0 commented on PR #7514: URL: https://github.com/apache/shenyu/pull/7514#issuecomment-6091339737
Thanks for the review — follow-up in the new commit: 1. **Processor type**: the referenced `DiscoveryDO` is now the source of truth — `chooseProcessor(discoveryDO.getDiscoveryType())` replaces the payload-derived type on the reference path (the create-new path keeps using the payload, which is the only source there). 2. **`fillDiscovery`**: acknowledged; left as-is to keep this follow-up minimal — the flag still carries meaning on the create-new branch (`insertSelective` result), and collapsing it would restructure both branches. Happy to do that cleanup as a separate refactor if preferred. 3. **Tests**: both rejection paths now also `verifyNoInteractions(discoveryHandlerMapper, discoveryRelMapper)`, and the accept test asserts the inserted `DiscoveryHandlerDO` carries the referenced `discoveryId`. 4. **`update()` gap**: agreed it deserves its own issue+PR — filed as a follow-up candidate and kept out of this change to hold the one-bug-one-PR scope. 3/3 green, `shenyu-admin` checkstyle clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
