Sean-Walker0 commented on PR #7515:
URL: https://github.com/apache/shenyu/pull/7515#issuecomment-6091303745
Great catch — the regression is real and is fixed in `fb11be190`.
- Only a **non-blank** reference is treated as a remappable target now; the
blank `selector_id` shape written by `ProxySelectorServiceImpl#create` (`''` in
the database) keeps its exported form instead of being nulled by
`mapping.get("")`.
- Added `testImportKeepsBlankSelectorIdShapeAndRemapsProxySelector`, which
replays exactly the rel shape you probed (`selectorId = ""`, `proxySelectorId`
remapped) and asserts the row is inserted with `selectorId = ""` and the
remapped `proxySelectorId`. It fails on the previous commit and passes now.
- Full class: 10/10 green, `shenyu-admin` checkstyle clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
