Aias00 commented on code in PR #7500:
URL: https://github.com/apache/shenyu/pull/7500#discussion_r4226658708
##########
shenyu-admin/src/main/resources/sql-script/h2/schema.sql:
##########
@@ -891,7 +890,6 @@ INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,
INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1529402613204172897', '38', 'clusterName', 'clusterName', 3, 3, 9,
'{"required":"1","defaultValue":"cluster"}');
INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1529402613204172777', '38', 'ttl', 'ttl', 3, 3, 10,
'{"required":"0","defaultValue":"30"}');
-INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1570590990341775360', '39', 'endpoint', 'casdoor endpoint', 2, 3, 0,
'{"required":"1","rule":""}');
INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1570591047635968000', '39', 'client_id', 'client_id', 2, 3, 0,
'{"required":"1","rule":""}');
Review Comment:
[MUST-FIX] The h2 schema deletes only the casdoor endpoint plugin_handle row
(1570590990341775360) but leaves five orphaned rows referencing plugin_id='39'
(client_id, client_secrect, certificate, organization-name, application-name).
The casdoor plugin row (id 39) is removed above, so these rows point at a
plugin that no longer exists in this schema. Every other dialect
(mysql/ob/og/oracle/pg) deletes all six casdoor plugin_handle rows. h2 is the
embedded/dev/admin-test database, so stale plugin_handle rows will surface
casdoor config fields in the admin for a plugin that is no longer shipped.
Please delete the remaining five rows so h2 matches the other five dialects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
