Aias00 commented on code in PR #7499: URL: https://github.com/apache/shenyu/pull/7499#discussion_r4226577886
########## shenyu-integrated-test/shenyu-integrated-test-http/src/test/java/org/apache/shenyu/integrated/test/http/HttpTestControllerTest.java: ########## @@ -21,7 +21,7 @@ import okhttp3.MultipartBody; import okhttp3.RequestBody; import okhttp3.Response; -import org.apache.commons.lang.RandomStringUtils; +import org.apache.commons.lang3.RandomStringUtils; Review Comment: [NIT] This `org.apache.commons.lang.RandomStringUtils` -> `org.apache.commons.lang3.RandomStringUtils` swap looks unrelated to the Hystrix externalization, but it is almost certainly a necessary fix: removing the hystrix starter drops hystrix-core 1.5.18's transitive `commons-lang` (lang2) from this module's classpath, so the lang2 `RandomStringUtils` would no longer resolve. Harmless if lang2 is still transitively present via shenyu-common; correct if hystrix-core was its only lang2 provider here. Just confirming the intent is captured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
