Aias00 opened a new issue, #7465:
URL: https://github.com/apache/shenyu/issues/7465

   ## Description
   The Spring SDK parameter processors read only `annotation.value()` for 
Spring MVC annotations. Spring treats `value` and `name` as aliases on 
`@RequestParam`, `@RequestHeader`, `@PathVariable`, and `@CookieValue`, but the 
SDK ignores `name()`.
   
   ## Location
   - `RequestParamParameterProcessor.java:48`
   - `RequestHeaderParameterProcessor.java:49`
   - `PathVariableParameterProcessor.java:45`
   - `CookieValueParameterProcessor.java:52`
   
   ## Impact
   Valid client declarations such as `@RequestParam(name = "id")` or 
`@RequestHeader(name = "X-Auth")` fail the SDK processor's non-empty checks or 
omit the intended data. These annotations are common in Spring code and should 
behave the same way in the SDK proxy.
   
   ## Suggested fix
   Resolve the effective annotation name from `value()` or `name()` for each 
processor. Add tests for name-only and value-only declarations.
   
   ## Related existing issues
   No duplicate found in the supplied issue and PR snapshots.
   
   ## Reviewed Revision And Validation
   
   Apache ShenYu 2.7.2-SNAPSHOT, master at 
a89b6a2338c24e978428b731e8f1edce86022418. Severity: medium. Confidence: high.
   
   Current Spring SDK annotation processor harness tested name-only 
annotations; source caller uses parameter annotations.
   
   Current source references:
   
   - 
`shenyu-sdk/shenyu-sdk-spring/src/main/java/org/apache/shenyu/sdk/spring/annotation/RequestParamParameterProcessor.java:48`
   - 
`shenyu-sdk/shenyu-sdk-spring/src/main/java/org/apache/shenyu/sdk/spring/annotation/RequestHeaderParameterProcessor.java:49`
   - 
`shenyu-sdk/shenyu-sdk-spring/src/main/java/org/apache/shenyu/sdk/spring/annotation/PathVariableParameterProcessor.java:45`
   - 
`shenyu-sdk/shenyu-sdk-spring/src/main/java/org/apache/shenyu/sdk/spring/annotation/CookieValueParameterProcessor.java:52`
   
   No implementation fix or full deployed end-to-end validation was performed 
by this review. Source-flow and runtime evidence are distinguished above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to