kalayciburak opened a new pull request, #7445:
URL: https://github.com/apache/shenyu/pull/7445
Fixes #7443.
### Description
`HttpShenyuSdkClient` looked up `http.connectionRequestTimeOut ` with a
trailing space. A property set with the ordinary key was ignored, and the
connection lease wait stayed at the 2000 ms default.
Read the key without the trailing space, matching the other `http.*`
properties. The default remains 2000 ms when the property is unset.
##### Key changed/added classes in this PR
* `HttpShenyuSdkClient`
This PR has:
- [x] been self-reviewed.
- [x] added unit tests or modified existing tests to cover new code paths.
### Test
`JAVA_HOME=17 ./mvnw test -pl shenyu-sdk/shenyu-sdk-httpclient -am
-Dtest=HttpShenyuSdkClientTest#testConnectionRequestTimeoutHonorsConfiguredProperty
-Dsurefire.failIfNoSpecifiedTests=false -Dmaven.javadoc.skip=true
-Drat.skip=true -Djacoco.skip=true`
RED: `expected:<50> but was:<2000>`.
Same command with `-Dtest=HttpShenyuSdkClientTest`: 8 tests, 0 failures.
Module checkstyle: 0 violations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
