terrymanu commented on code in PR #19777:
URL: https://github.com/apache/shardingsphere/pull/19777#discussion_r935155969
##########
shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/datasource/ShardingSphereDataSource.java:
##########
@@ -69,8 +70,9 @@ private ContextManager createContextManager(final String
databaseName, final Mod
final
Collection<RuleConfiguration> ruleConfigs, final Properties props) throws
SQLException {
InstanceMetaData instanceMetaData =
InstanceMetaDataBuilderFactory.create("JDBC", -1);
Collection<RuleConfiguration> globalRuleConfigs =
ruleConfigs.stream().filter(each -> each instanceof
GlobalRuleConfiguration).collect(Collectors.toList());
+ Collection<RuleConfiguration> realRuleConfigs =
ruleConfigs.stream().filter(each -> !(each instanceof
SQLParserRuleConfiguration)).collect(Collectors.toList());
Review Comment:
Please change SQLParserRuleConfiguration to GlobalRuleConfiguration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
