sandynz commented on code in PR #19356:
URL: https://github.com/apache/shardingsphere/pull/19356#discussion_r925207489
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/check/datasource/PostgreSQLDataSourceChecker.java:
##########
@@ -17,18 +17,57 @@
package org.apache.shardingsphere.data.pipeline.postgresql.check.datasource;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.StringUtils;
import
org.apache.shardingsphere.data.pipeline.core.check.datasource.AbstractDataSourceChecker;
+import
org.apache.shardingsphere.data.pipeline.core.exception.PipelineJobPrepareFailedException;
import javax.sql.DataSource;
+import java.sql.Connection;
+import java.sql.DatabaseMetaData;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.SQLException;
import java.util.Collection;
/**
* PostgreSQL Data source checker.
*/
+@Slf4j
public class PostgreSQLDataSourceChecker extends AbstractDataSourceChecker {
+ private static final String SHOW_GRANTS_SQL = "SELECT * FROM pg_roles
WHERE rolname = ?";
+
+ private static final String SUPER_ROLE_NAME = "rolsuper";
+
+ private static final String REPLICATION_ROLE_NAME = "rolreplication";
+
@Override
public void checkPrivilege(final Collection<? extends DataSource>
dataSources) {
+ for (DataSource each : dataSources) {
+ checkPrivilege(each);
+ }
+ }
+
+ private void checkPrivilege(final DataSource dataSource) {
+ try (Connection connection = dataSource.getConnection();
PreparedStatement preparedStatement =
connection.prepareStatement(SHOW_GRANTS_SQL)) {
+ DatabaseMetaData metaData = connection.getMetaData();
+ preparedStatement.setString(1, metaData.getUserName());
+ try (ResultSet resultSet = preparedStatement.executeQuery()) {
+ if (!resultSet.next()) {
+ throw new
PipelineJobPrepareFailedException(String.format("No role exists, rolname: %s.",
metaData.getUserName()));
+ }
+ String isSuperRole = resultSet.getString(SUPER_ROLE_NAME);
+ String isReplicationRole =
resultSet.getString(REPLICATION_ROLE_NAME);
+ log.info("checkPrivilege: isSuperRole: {}, isReplicationRole:
{}", isSuperRole, isReplicationRole);
+ if (StringUtils.equalsIgnoreCase(isSuperRole, "f") &&
StringUtils.equalsIgnoreCase(isReplicationRole, "f")) {
+ throw new
PipelineJobPrepareFailedException(String.format("Source data source is lack of
REPLICATION privileges, sql example is `ALTER ROLE \"%s\" REPLICATION;`.",
+ metaData.getUserName()));
Review Comment:
`sql example is` could be `you could try`
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/check/datasource/PostgreSQLDataSourceChecker.java:
##########
@@ -17,18 +17,57 @@
package org.apache.shardingsphere.data.pipeline.postgresql.check.datasource;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.StringUtils;
import
org.apache.shardingsphere.data.pipeline.core.check.datasource.AbstractDataSourceChecker;
+import
org.apache.shardingsphere.data.pipeline.core.exception.PipelineJobPrepareFailedException;
import javax.sql.DataSource;
+import java.sql.Connection;
+import java.sql.DatabaseMetaData;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.SQLException;
import java.util.Collection;
/**
* PostgreSQL Data source checker.
*/
+@Slf4j
public class PostgreSQLDataSourceChecker extends AbstractDataSourceChecker {
+ private static final String SHOW_GRANTS_SQL = "SELECT * FROM pg_roles
WHERE rolname = ?";
+
+ private static final String SUPER_ROLE_NAME = "rolsuper";
+
+ private static final String REPLICATION_ROLE_NAME = "rolreplication";
Review Comment:
Could we just inline these string? It's short enough and just used one time.
Or could we change it to xxx_COLUMN_NAME? It's not ROLE NAME.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
